Create Profile File Provider for Region #682
Conversation
As part of this work, I unified handling of provider configuration into `ProviderConfig`. This simplifies and removes boilerplate from the credential provider builders.
| #[derive(Debug)] | ||
| pub struct DefaultRegionChain(RegionProviderChain); | ||
|
|
||
| impl DefaultRegionChain { |
There was a problem hiding this comment.
Should this have a builder() method like DefaultCredentialsChain?
| let region_chain = self.region_chain; | ||
| let region = self | ||
| .region_override | ||
| .unwrap_or_else(move || Box::new(region_chain.build())) |
There was a problem hiding this comment.
Nit: seems like there should be a way to do this fallback without boxing.
| mod sleep { | ||
| use smithy_async::rt::sleep::{AsyncSleep, TokioSleep}; | ||
| use std::sync::Arc; | ||
|
|
||
| #[cfg(feature = "rt-tokio")] | ||
| pub fn default_sleep() -> Option<Arc<dyn AsyncSleep>> { | ||
| Some(Arc::new(TokioSleep::new())) | ||
| } | ||
|
|
||
| #[cfg(not(feature = "rt-tokio"))] | ||
| pub fn default_sleep() -> Option<Arc<dyn AsyncSleep>> { | ||
| None | ||
| } |
There was a problem hiding this comment.
Is this done here so that it can be an Arc<dyn rather than the Box<dyn that smithy-async returns? Should we add an alternate set of arc functions to smithy-async so that the feature logic doesn't need to be repeated? Or maybe we just decide to always make these runtime implementations Arc to simplify things? Maybe we even new-type Arc<dyn AsyncSleep> to DynAsyncSleep to hide the detail as well.
Edit: Looks like you did some of this in smithy-async in this PR.
| /// use aws_config::provider_config::ProviderConfig; | ||
| /// use aws_sdk_sts::Region; | ||
| /// use aws_config::web_identity_token::WebIdentityTokenCredentialsProvider; | ||
| /// let conf = ProviderConfig::without_region().with_region(Some(Region::new("us-east-1"))); |
There was a problem hiding this comment.
without_region followed by with_region is a bit of a head scratcher, but I'm not sure I have a better suggestion. Maybe without_default_region, but then you can follow that with load_default_region and have the same problem.
Co-authored-by: John DiSanti <jdisanti@amazon.com>
Motivation and Context
Although credentials can be loaded from the AWS profile, the profile was ignored when resolving regions.
Description
ProviderConfig. This simplifies and removes boilerplate from the credential provider builders.Testing
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.