Remove the simple-mutex dependency #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that this was originally done when std::sync::Mutex used the PThreads implementation, which was much slower than other contemporary Mutex implementations (like parking_lot). Therefore it made sense to use a custom Mutex implementation here. However std Mutexes now use futexes, which are much faster than the previous implementation. In addition, the original git history for simple-mutex appears to be lost to time. The only copy of the source code is on crates.io, and the crate is not owned by anyone. So it is problematic to use it anyways, as updating it would require us to go through the painstaking process of reclaiming the name. This commit removes the dependency on simple-mutex and replaces its usages with std::sync::Mutex for the reasons listed above. The performance impact of this change has not been measured, but I believe it to be negligible. Signed-off-by: John Nunley <dev@notgull.net>
Signed-off-by: John Nunley <dev@notgull.net>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that this was originally done when std::sync::Mutex used the PThreads implementation, which was much slower than other contemporary Mutex implementations (like parking_lot). Therefore it made sense to use a custom Mutex implementation here. However std Mutexes now use futexes, which are much faster than the previous implementation.
In addition, the original git history for simple-mutex appears to be lost to time. The only copy of the source code is on crates.io, and the crate is not owned by anyone. So it is problematic to use it anyways, as updating it would require us to go through the painstaking process of reclaiming the name.
This commit removes the dependency on simple-mutex and replaces its usages with std::sync::Mutex for the reasons listed above. The performance impact of this change has not been measured, but I believe it to be negligible.