Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

coding wrappers #44

Closed
cmeesters opened this issue Nov 24, 2023 · 7 comments · Fixed by #95
Closed

coding wrappers #44

cmeesters opened this issue Nov 24, 2023 · 7 comments · Fixed by #95
Assignees
@brand-fabian
Labels
enhancement New feature or request

Comments

@cmeesters
Copy link
Member

new section on how to code wrappers, assigned to @brand-fabian according to meeting notes from 2023-11-10
@cmeesters cmeesters added the enhancement New feature or request label Nov 24, 2023
@cmeesters
Copy link
Member Author

also see issue #18

brand-fabian pushed a commit that referenced this issue Dec 15, 2023
feat: Adding slides explaining the setup, usage and creation of snake…
1462a6c 
…make wrappers.

This is a first attempt to provide some slides to explain all aspects
of wrappers in some depth.

Refs: #44
@brand-fabian
Copy link
Collaborator

I have added a first version of slides explaining how to use and create wrappers on the linked branch. It would be great if you could provide some feedback, whether this is the right direction, what is missing, etc.

Next I would get to fixing the alignment of the code blocks and adding some images and more examples in general.

@cmeesters
Copy link
Member Author

cmeesters commented Dec 15, 2023 •
edited
Loading

Thank you for your contribution! Looks good at first glance. 2.5 points:

  1. The common section might merit a how-to-install-wrappers slide, resp. the note that snakemake will take care and that you can point to a directory, alternatively.
  2. be aware that when using onlyenv a handout will only contain the last slide.
  3. please use \texttt{Snakemake} for the project and \altverb{snakemake} , respectively. The first looks ugly and is subject to change (see Snakemake logo on title page and improve Snakemake typesetting  #49). Using coherent commands will make a subsequent layout change easy.

@brand-fabian
Copy link
Collaborator

Thanks for the remarks, didnt know about 2 & 3 and will take a look at how I can fix this. Also I agree to the first point, maybe adding a slide in general about the different ways of addressing wrappers (file, default repository, own repositories...).

@cmeesters
Copy link
Member Author

oh, I totally forgot! Could you please do a PR? We should polish and merge a.s.a.p.. Thank you!

@cmeesters
Copy link
Member Author

done the PR #67 . see there.

brand-fabian pushed a commit that referenced this issue Feb 6, 2024
feat: Adding slides explaining the setup, usage and creation of snake…
f934787 
…make wrappers.

This is a first attempt to provide some slides to explain all aspects
of wrappers in some depth.

Refs: #44
brand-fabian pushed a commit that referenced this issue Feb 6, 2024
fix: Preparing to merge wrappers into main.
a73e1e1 
Merge branch 'brand-wrappers' of https://github.com/cmeesters/snakemake-hpc-teaching-material into brand-wrappers

Refs: #67, #44
@cmeesters
Copy link
Member Author

done, for PR is done

@github-actions github-actions bot mentioned this issue May 15, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@brand-fabian brand-fabian

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(main): release 1.0.0 snakemake/snakemake-hpc-teaching-material
2 participants
@cmeesters @brand-fabian