Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expose the function to identify isotopes? #51

Open
jorainer opened this issue Mar 18, 2020 · 4 comments
Open

Expose the function to identify isotopes? #51

jorainer opened this issue Mar 18, 2020 · 4 comments

Comments

@jorainer
Copy link

Dear developers (@sneumann @Treutler) I wanted to ask if it would be possible to expose/export some CAMERA-internal core functionality as documented functions?

The reason for that: I think it would be helpful to be able to call some of the core functionality from CAMERA also from other packages or independently of CAMERA (and more importantly, the xcmsSet object). This would open up CAMERA also for other types of input data, e.g. if you just have a list of m/z and intensity values, find possible isotopes. And that is actually exactly my use case at the moment: I have a set of m/z values and related intensity values and would like to know which or if these could be isotopes from each other. So, is there a function in CAMERA that takes mz and intensity values and can predict isotopes on that? And if so, which is it and how can I call that?

@stanstrup
Copy link
Contributor

Not tried it but seems you are looking for findIsotopesPspec in:

findIsotopesPspec <- function(isomatrix, mz, ipeak, int, params){

Some post-proccesing seems to be going on so perhaps there is not a single function that can be used direct:

isomatrix <- findIsotopesPspec(isomatrix, mz, ipeak, int, params)

@jorainer
Copy link
Author

Thanks Jan! Yes I've also seen this function - but it's hard to understand what the individual parameters mean or are. But yes, I would like to have e.g. this function exported (and documented).

@sneumann
Copy link
Owner

Hi, I am open for PR and can (try) to help. But Carsten Kuhl is long gone from my group :-(

jorainer added a commit to jorainer/CAMERA that referenced this issue Mar 20, 2020
- Export the core functionality to find isotopes among a grouped set of
  features (aka pseudo spectrum). Issue sneumann#51.
@jorainer
Copy link
Author

I've just realized that there is a second way to find isotopes: findIsotopesWithValidation - which uses a completely different code basis to find isotopes. @sneumann is this one supposed to be the better approach that should be used by default now?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants