Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

make the json serialization of kotlin object the same as the rust one #133

Merged
merged 1 commit into from
Apr 2, 2019
Merged

make the json serialization of kotlin object the same as the rust one #133

merged 1 commit into from
Apr 2, 2019

Conversation

fredszaq
Copy link
Contributor

@fredszaq fredszaq commented Apr 1, 2019

No description provided.

gstraymond
gstraymond reviewed Apr 1, 2019
View reviewed changes
Copy link
Contributor

@gstraymond gstraymond left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no tests in this PR ?

Are they located elsewhere ?

@fredszaq
Copy link
Contributor Author

fredszaq commented Apr 1, 2019

@gstraymond I've got roundtrip tests in the hermes pr that is to come and that depends on this....

gstraymond
gstraymond approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@gstraymond gstraymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦌

@adrienball adrienball merged commit d490914 into develop Apr 2, 2019
@adrienball adrienball deleted the kotlin-json-serialization-fixes branch April 2, 2019 12:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gstraymond gstraymond gstraymond approved these changes

@adrienball adrienball adrienball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredszaq @gstraymond @adrienball