Add geographical entities #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClemDoum
force-pushed
the
feature/geographical-entities
branch
from
c82a650 to
db6e15b
Compare
ClemDoum
force-pushed
the
feature/geographical-entities
branch
from
6549062 to
71c4d2b
Compare
adrienball
requested changes
Jul 11, 2019
CHANGELOG.md
Outdated
| @@ -1,6 +1,11 @@ | |||
| # Changelog | |||
| All notable changes to this project will be documented in this file. | |||
|
|
|||
| ## [Unrealeased] | |||
There was a problem hiding this comment.
Unrealeased --> Unreleased
CHANGELOG.md
Outdated
| @@ -179,6 +184,7 @@ All notable changes to this project will be documented in this file. | |||
| ### Changed | |||
| - Updated Rustling ontology to `0.16.4` | |||
|
|
|||
| [Unrealeased]: https://github.com/snipsco/snips-nlu-ontology/compare/0.64.8...HEAD | |||
There was a problem hiding this comment.
Unrealeased --> Unreleased
ClemDoum
force-pushed
the
feature/geographical-entities
branch
from
71c4d2b to
63f0798
Compare
adrienball
requested changes
Jul 11, 2019
| Type(value = MusicTrackValue::class, name = "MusicTrack"), | ||
| Type(value = City::class, name = "City"), | ||
| Type(value = Country::class, name = "Country"), | ||
| Type(value = Region::class, name = "Region") |
There was a problem hiding this comment.
City --> CityValue
Country --> CountryValue
Region --> RegionValue
adrienball
approved these changes
Jul 11, 2019
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for City, Country and Region in all languages