Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add noise re-weight factor #815

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Add noise re-weight factor #815

merged 2 commits into from
Jun 26, 2019

Conversation

adrienball
Copy link
Contributor

Description:
This PR introduces a new parameter in the LogRegIntentClassifierConfig which is named noise_reweight_factor.
This parameter allows to deviate from the default "balanced" class weight strategy by multiplying the Noise class weight by a given factor.
Typically, using noise_reweight_factor > 1 will end up in a more conservative engine, meaning that it will predict None more often, and vice versa.

Checklist:

  • My PR is ready for code review
  • I have added some tests, if applicable, and run the whole test suite, including linting tests
  • I have updated the documentation, if applicable

@codecov-io
Copy link

Codecov Report

Merging #815 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #815      +/-   ##
===========================================
+ Coverage    88.47%   88.48%   +0.01%     
===========================================
  Files           76       76              
  Lines         4608     4613       +5     
  Branches       894      895       +1     
===========================================
+ Hits          4077     4082       +5     
  Misses         395      395              
  Partials       136      136

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #815 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #815      +/-   ##
===========================================
+ Coverage    88.47%   88.48%   +0.01%     
===========================================
  Files           76       76              
  Lines         4608     4613       +5     
  Branches       894      895       +1     
===========================================
+ Hits          4077     4082       +5     
  Misses         395      395              
  Partials       136      136

@adrienball adrienball merged commit 2fb6381 into develop Jun 26, 2019
@adrienball adrienball deleted the task/out-of-domain branch June 26, 2019 15:51
@ClemDoum ClemDoum mentioned this pull request Jul 10, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants