Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Revamp cli #819

Merged
merged 11 commits into from
Jul 9, 2019
Merged

Revamp cli #819

merged 11 commits into from
Jul 9, 2019

Conversation

adrienball
Copy link
Contributor

Description:

  • Import modules lazily to speed up the CLI startup time
  • Use argparse in conjuction with subparsers instead of plac
  • Add a random_seed parameter to the training CLI (addresses Pass a seeding value to the fit method #816)

Checklist:

  • My PR is ready for code review
  • I have added some tests, if applicable, and run the whole test suite, including linting tests
  • I have updated the documentation, if applicable

@adrienball adrienball requested a review from ClemDoum July 2, 2019 17:10
@adrienball adrienball mentioned this pull request Jul 2, 2019
Closed
@adrienball adrienball merged commit 38983de into develop Jul 9, 2019
@adrienball adrienball deleted the task/revamp-cli branch July 9, 2019 16:20
@ClemDoum ClemDoum mentioned this pull request Jul 10, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ClemDoum ClemDoum ClemDoum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrienball @ClemDoum