Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow to bypass version check #830

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Allow to bypass version check #830

merged 2 commits into from
Jul 17, 2019

Conversation

adrienball
Copy link
Contributor

Description:
This PR adds the ability to bypass the model version check which is performed when loading an nlu engine with the from_path API:

from snips_nlu import SnipsNLUEngine

engine = SnipsNLUEngine.from_path("path/to/nlu_engine", bypass_version_check=True)

The version check is there to ensure compatibility between the loader (the library itself) and the loaded (the trained engine directory/bytes). If the two versions don't match, then an error is raised and the loading is stopped.
The actual incompatibility often depends on the NLU configuration used, which is why it can be useful to disable this check for cases where the trained data is known to be compatible with the new version of the library. In such cases, a warning log will be emitted.

Checklist:

  • My PR is ready for code review
  • I have added some tests, if applicable, and run the whole test suite, including linting tests
  • I have updated the documentation, if applicable

@adrienball adrienball requested a review from ClemDoum July 16, 2019 15:06
@adrienball adrienball merged commit 1176c44 into master Jul 17, 2019
@adrienball adrienball deleted the task/bypass-version-check branch July 17, 2019 15:44
@ClemDoum ClemDoum mentioned this pull request Sep 4, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants