Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handle license #832

Merged
merged 4 commits into from
Jul 23, 2019
Merged

Handle license #832

merged 4 commits into from
Jul 23, 2019

Conversation

ClemDoum
Copy link
Collaborator

@ClemDoum ClemDoum commented Jul 18, 2019

Description:
In some case the dataset might contain data subject to license terms that need to be placed next to the parsers built from this data.

When fitting the custom entity parser, if the dataset contains license information, the gazetteer entity parser are build with license_info (snips-nlu-parser>=0.3.1) which ensure that the license will be persisted at the right location when persisting the engine

Checklist:

  • My PR is ready for code review
  • I have added some tests, if applicable, and run the whole test suite, including linting tests
  • I have updated the documentation, if applicable

@codecov-io
Copy link

Codecov Report

Merging #832 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #832      +/-   ##
==========================================
+ Coverage   88.95%   88.96%   +0.01%     
==========================================
  Files          79       79              
  Lines        5090     5095       +5     
  Branches      966      968       +2     
==========================================
+ Hits         4528     4533       +5     
  Misses        417      417              
  Partials      145      145

@adrienball adrienball merged commit 9878be3 into master Jul 23, 2019
@adrienball adrienball deleted the feature/handle-data-license branch July 23, 2019 16:13
@ClemDoum ClemDoum mentioned this pull request Sep 4, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants