Float types are not supported

[igor-plotnikov]

Float types are not supported, comparing JSON with a float type throws an error

[igor-plotnikov]

Add a case for floats to walker.go:

	if modified.Bool() != current.Bool() {
		w.replace(pointer, modified.Bool(), current.Bool())
	}
case reflect.Float64, reflect.Float32:
	if modified.Float() != current.Float() {
		w.replace(pointer, modified.Float(), current.Float())
	}
case reflect.Invalid:
	// undefined interfaces are ignored for now
	return nil

and to patch_test.go:

Uint32  uint32  `json:"uint32"`
Uint64  uint64  `json:"uint64"`
UintPtr uintptr `json:"ptr" faker:"-"`
Float32   float32   `json:"float32"`
Float64   float64   `json:"float64"`

}

It works for me.

[snorwin]

Hi @igor-plotnikov,
Thank you for submitting an issue, feel free to create a pull request with the suggested changes.

Cheers,
Norwin

[igor-plotnikov]

Norwin, I've tried to create a branch with the fix, but I don't have the write rights for your repository Regards Igor

…

On Tue, Nov 23, 2021 at 1:53 AM Norwin Schnyder ***@***.***> wrote: Hi @igor-plotnikov <https://github.com/igor-plotnikov>, Thank you for submitting an issue, feel free to create a pull request with the suggested changes. Cheers, Norwin — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANUMOA5Q6TRITNMGSDKKCBLUNNQCTANCNFSM5ISWU2CQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[snorwin]

You need to create a fork first (https://docs.github.com/en/get-started/quickstart/fork-a-repo). On you personal fork you then can create branches and PR to the main branch of this repo here.

[johanneswuerbach]

@snorwin would you have time to look into any of the provided PRs. That would be amazing 🤩