Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Release/r157 #1400

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Release/r157 #1400

merged 2 commits into from
Apr 2, 2024

Conversation

jbeemster
Copy link
Member

No description provided.

@jbeemster jbeemster requested review from igneel64 and cksnp April 2, 2024 10:57
@jbeemster jbeemster self-assigned this Apr 2, 2024
@igneel64 igneel64 requested a review from matus-tomlein April 2, 2024 13:41
matus-tomlein
matus-tomlein approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Had a nitpick about accepting null in the properties, but that was the case also in the previous versions of the schema, so not a blocker.

schemas/com.snowplowanalytics.snowplow/event_specification/jsonschema/1-0-2 Outdated Show resolved Hide resolved
@jbeemster jbeemster merged commit dd45d7e into master Apr 2, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@igneel64 igneel64 igneel64 approved these changes

@cksnp cksnp cksnp approved these changes

@matus-tomlein matus-tomlein matus-tomlein approved these changes

Assignees

@jbeemster jbeemster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbeemster @matus-tomlein @igneel64 @cksnp