Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add a random number templating function #109

Merged
merged 1 commit into from
Jan 10, 2018
Merged

Add a random number templating function #109

merged 1 commit into from
Jan 10, 2018

Conversation

tclass
Copy link
Contributor

@tclass tclass commented Dec 20, 2017

issue #23

@coveralls
Copy link

coveralls commented Dec 20, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 32.411% when pulling 7fb603c on justwatchcom:feature/random_number_func into 0ae72da on snowplow:master.

BenFradet
BenFradet approved these changes Dec 20, 2017
View reviewed changes
Copy link

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@BenFradet BenFradet changed the title adds a random number function to the templating Add a random number templating function Dec 20, 2017
@BenFradet BenFradet added this to the Version 0.6.0 milestone Dec 20, 2017
@snowplowcla
Copy link

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@alexanderdean
Copy link
Member

CLA not signed yet, pushing back

@tclass
Copy link
Contributor Author

tclass commented Jan 9, 2018

I signed it!

@snowplowcla
Copy link

Confirmed! @tclass has signed the Individual Contributor License Agreement. Thanks so much

@BenFradet BenFradet changed the base branch from master to develop January 10, 2018 16:50
@BenFradet
Copy link

Thanks merging 👍

@BenFradet BenFradet merged commit 06e9c50 into snowplow:develop Jan 10, 2018
mhadam pushed a commit that referenced this pull request Jul 6, 2018
@tclass @mhadam
Add a random number templating function (close #109)
f52929d
mhadam pushed a commit that referenced this pull request Jul 9, 2018
@tclass @mhadam
Add a random number templating function (close #109)
6fb0ea3
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@BenFradet BenFradet BenFradet approved these changes

Assignees

@BenFradet BenFradet

@mhadam mhadam

Labels
cla: yes
Projects
None yet
Milestone
Version 0.7.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tclass @coveralls @snowplowcla @alexanderdean @BenFradet @mhadam