Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: improve documentation #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: improve documentation #13

wants to merge 2 commits into from

Conversation

atcol
Copy link
Collaborator

@atcol atcol commented Oct 27, 2024

Some small improvements to documentation. More to come -- want to build better examples first.

@atcol
Copy link
Collaborator Author

atcol commented Oct 27, 2024

BTW, the tests fail on lack of Icon for the test DB -- do you know how long it can take to see the change on a database? I added an Icon and it's not visible in the results...Perhaps PEBKAC, it's late here.

@atcol atcol requested a review from b3ngg October 27, 2024 21:44
Copy link
Member

@b3ngg b3ngg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. The docs definitely need improvements. Also, a quick start in the README would be awesome, I think. And the current example is absolutely garbage…

@atcol
Copy link
Collaborator Author

atcol commented Oct 28, 2024

Ok I'll tweak that.

Any advice on getting the database icon test to work?

@b3ngg
Copy link
Member

b3ngg commented Oct 28, 2024

Test seem to fail because of the doctests. Gonna need to either ignore them or use something like https://docs.rs/tokio-test/0.3.0/tokio_test/fn.block_on.html to make it work with async.

@b3ngg
Copy link
Member

b3ngg commented Oct 28, 2024

BTW, the tests fail on lack of Icon for the test DB -- do you know how long it can take to see the change on a database? I added an Icon and it's not visible in the results...Perhaps PEBKAC, it's late here.

Changes should propagate instantly. Do you have your own test DB duplicated, or are you using the one from .example.env? I can also give you access to the example one so you can make changes there. It might be easier. Just comment on the page, and I will add you.
I'm not sure if I'm understanding your problem correctly.

@atcol
Copy link
Collaborator Author

atcol commented Oct 28, 2024

Good stuff. The docs definitely need improvements. Also, a quick start in the README would be awesome, I think. And the current example is absolutely garbage…

BTW do you mean change the example I added or somewhere else? I don't think there's an example in the README

@b3ngg
Copy link
Member

b3ngg commented Oct 28, 2024

BTW do you mean change the example I added or somewhere else? I don't think there's an example in the README

No, your example is great. I mean the examples/todo directory. It doesn't even actually use the library. xD
I already removed the link from the README when adjusting it after the fork. I also have a PR lined up to delete it because this example is actually the reason why we need Tokio as a dependency and not just as a dev-dependency, thus being the only reason why the crate is not WASM-compatible.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants