[CAY-1207] Decouple Pregel framework from pagerank app #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wynot12
reviewed
Jul 20, 2017
|
|
||
| @Override | ||
| public PregelConfiguration build() { | ||
| return new PregelConfiguration(this); |
There was a problem hiding this comment.
Passing each ingredient looks better than a builder.
Then we don't need get methods in Builder class.
wynot12
reviewed
Jul 21, 2017
| @@ -105,15 +108,15 @@ public Builder setMessageCodecClass(final Class<? extends Codec> messageCodecCla | |||
| return this; | |||
| } | |||
|
|
|||
| public Builder setMessageUpdateFunctionClass(final Class<? extends UpdateFunction> updateFunctionClass) { | |||
| this.messageUpdateFunctionClass = updateFunctionClass; | |||
| public Builder addParameterClass(final Class<? extends Name<?>> parameterClass) { | |||
There was a problem hiding this comment.
It's for future usage, right?
There was a problem hiding this comment.
#1178 may use this feature, right?
|
LGTM! |
wynot12
approved these changes
Jul 21, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1207
Using
PregelConfiguration, users can launch the Pregel according to the desired setting.For example,
PagerankETlaunches pagerank app on Pregel.