Merge pull request #560 from snyk/feat/capture-latency-on-ping

feat: capture latency upon ping
snyk · Jun 5, 2023 · a9f89b4 · a9f89b4
2 parents 2a94dbb + 7d87deb
commit a9f89b4
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 7 deletions.
diff --git a/lib/dispatcher.js b/lib/dispatcher.js
@@ -46,11 +46,15 @@ class DispatcherClient {
     clientId,
     clientVersion,
     requestType = 'client-connected',
+    time = -1,
   ) {
     const hashedToken = hashToken(token);
-    const queryStringParams = clientId
+    let queryStringParams = clientId
       ? `?broker_client_id=${clientId}&request_type=${requestType}`
       : '';
+    if (time != -1) {
+      queryStringParams = queryStringParams + `&latency=${Date.now() - time}`;
+    }
     await this.#makeRequest(
       { hashedToken, clientId, requestType: requestType },
       `${this.#url}/internal/brokerservers/${
@@ -159,8 +163,14 @@ if (config.dispatcherUrl) {
     return kc.clientConnected(token, clientId, clientVersion);
   };
 
-  clientPinged = async function (token, clientId, clientVersion) {
-    return kc.clientConnected(token, clientId, clientVersion, 'client-pinged');
+  clientPinged = async function (token, clientId, clientVersion, time) {
+    return kc.clientConnected(
+      token,
+      clientId,
+      clientVersion,
+      'client-pinged',
+      time,
+    );
   };
 
   clientDisconnected = async function (token, clientId) {

diff --git a/lib/server/socket.js b/lib/server/socket.js
@@ -132,10 +132,10 @@ module.exports = ({ server, filters, config }) => {
 
       socket.on('chunk', streamingResponse(token));
       socket.on('request', response(token));
-      socket.on('incoming::ping', () => {
+      socket.on('incoming::ping', (time) => {
         setImmediate(
           async () =>
-            await dispatcher.clientPinged(token, clientId, clientVersion),
+            await dispatcher.clientPinged(token, clientId, clientVersion, time),
         );
       });
 

diff --git a/test/functional/dispatcher-server-api.test.ts b/test/functional/dispatcher-server-api.test.ts
@@ -65,9 +65,11 @@ describe('Broker Server Dispatcher API interaction', () => {
   });
 
   it('should fire off clientPinged call successfully with server response', async () => {
+    const time = Date.now();
+    const fakeLatency = 1;
     nock(`${serverUrl}`)
       .post(
-        `/internal/brokerservers/0/connections/${hashedToken}?broker_client_id=${clientId}&request_type=client-pinged&version=${apiVersion}`,
+        `/internal/brokerservers/0/connections/${hashedToken}?broker_client_id=${clientId}&request_type=client-pinged&latency=${fakeLatency}&version=${apiVersion}`,
       )
       .reply((uri, requestBody) => {
         spyFn(JSON.parse(requestBody));
@@ -79,7 +81,12 @@ describe('Broker Server Dispatcher API interaction', () => {
       process.env.hostname = '0';
       const dispatcher = require('../../lib/dispatcher');
       await expect(
-        dispatcher.clientPinged(token, clientId, clientVersion),
+        dispatcher.clientPinged(
+          token,
+          clientId,
+          clientVersion,
+          time - fakeLatency,
+        ),
       ).resolves.not.toThrowError();
       expect(spyLogWarn).toHaveBeenCalledTimes(0);
       expect(spyFn).toBeCalledWith({