Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: properly structure qs params in dispatcher calls #561

Merged
merged 1 commit into from
Jun 5, 2023
Merged

fix: properly structure qs params in dispatcher calls #561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions lib/dispatcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,22 @@ class DispatcherClient {
time = -1,
) {
const hashedToken = hashToken(token);
let queryStringParams = clientId
? `?broker_client_id=${clientId}&request_type=${requestType}`
: '';
const url = new URL(
`${this.#url}/internal/brokerservers/${
this.#id
}/connections/${hashedToken}`,
);
if (clientId) {
url.searchParams.append('broker_client_id', clientId);
}
if (time != -1) {
queryStringParams = queryStringParams + `&latency=${Date.now() - time}`;
url.searchParams.append('latency', Date.now() - time);
}
url.searchParams.append('request_type', requestType);

await this.#makeRequest(
{ hashedToken, clientId, requestType: requestType },
`${this.#url}/internal/brokerservers/${
this.#id
}/connections/${hashedToken}${queryStringParams}`,
url.toString(),
'post',
{
data: {
Expand Down