Run tests on the minified files #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrachequesne
force-pushed
the
fix/minified
branch
from
607a4e1 to
b160f0a
Compare
2 tasks
15 tasks
darrachequesne
force-pushed
the
fix/minified
branch
from
cedf6b9 to
4583d9c
Compare
|
The output seems valid for IE8 (tested with virtualbox), yet I don't know where the error |
2 tasks
2 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the uglify step in the webpack process, so that zuul tests are made on the minified versions.
That should prevent #1040 (and #1034)
Also fixes socketio/socket.io#2777
Breaking change: the minified version would now be called
socket.io.js(and notsocket.io.min.js), and the.minfiles would be deleted.