Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

changed stated io(url) default values #343

Closed
wants to merge 1 commit into from

Conversation

DagnirCuthalion
Copy link

Based on https://github.com/socketio/socket.io-client/blob/main/dist/socket.io.js#L3964 the default is neither window.location nor / but instead /socket.io

Based on https://github.com/socketio/socket.io-client/blob/main/dist/socket.io.js#L3964 the default is neither `window.location` nor `/` but instead `/socket.io`
@vercel
Copy link

vercel bot commented Jun 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
socket-io-website ✅ Ready (Inspect) Visit Preview Jun 20, 2022 at 1:28PM (UTC)

darrachequesne pushed a commit that referenced this pull request Nov 25, 2022
Change `window.location` to `window.location.host`. If
`io(window.location)` is started, it works, but then if we pass
`options`, those are ignored.

Related:

- #139
- #343
@darrachequesne
Copy link
Member

Included in 4cb010f. Thanks 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants