Skip to content

Commit

Permalink
[chore] Drop support for old nodejs versions (0.10 & 0.12) (#493)
Browse files Browse the repository at this point in the history
  • Loading branch information
darrachequesne authored Mar 11, 2017
1 parent 783e059 commit b436ca3
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 26 deletions.
11 changes: 0 additions & 11 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,10 @@
sudo: false
language: node_js
node_js:
- "0.10"
- "0.12"
- "4"
- "6"
- "7"
git:
depth: 1
env:
- CXX=g++-4.8
addons:
apt:
sources:
- ubuntu-toolchain-r-test
packages:
- g++-4.8

notifications:
irc: "irc.freenode.org#socket.io"
28 changes: 13 additions & 15 deletions test/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -2603,23 +2603,21 @@ describe('server', function () {
});
});

if (!UWS_ENGINE && parseInt(process.versions.node, 10) >= 4) {
describe('wsEngine option', function () {
it('should allow loading of other websocket server implementation like uws', function (done) {
var engine = listen({ allowUpgrades: false, wsEngine: 'uws' }, function (port) {
expect(engine.ws instanceof require('uws').Server).to.be.ok();
var socket = new eioc.Socket('ws://localhost:%d'.s(port));
engine.on('connection', function (conn) {
conn.send('a');
});
socket.on('open', function () {
socket.on('message', function (msg) {
expect(msg).to.be('a');
done();
});
describe('wsEngine option', function () {
it('should allow loading of other websocket server implementation like uws', function (done) {
var engine = listen({ allowUpgrades: false, wsEngine: 'uws' }, function (port) {
expect(engine.ws instanceof require('uws').Server).to.be.ok();
var socket = new eioc.Socket('ws://localhost:%d'.s(port));
engine.on('connection', function (conn) {
conn.send('a');
});
socket.on('open', function () {
socket.on('message', function (msg) {
expect(msg).to.be('a');
done();
});
});
});
});
}
});
});

0 comments on commit b436ca3

Please # to comment.