client.ts > _packet() > writeToEngine() argument type #3775
Labels
bug
Something isn't working
Comments
darrachequesne
added a commit
to socketio/socket.io-adapter
that referenced
this issue
May 10, 2021
A few notes: - only the first element is pre-encoded, because the other elements are buffers and will be sent as is over the WebSocket connection - using `socket.packet()` was unexpectedly working, we will now use `socket.client.writeToEngine()` (see [1]) See also: socketio/engine.io@7706b12 [1]: socketio/socket.io#3775
|
You are totally right, this worked but didn't make sense at all. The adapter now calls |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Describe the bug
I do not know if this is a bug. I came across some code that doesn't seem to make sense from a typings point of view:
https://github.com/socketio/socket.io/blob/master/lib/client.ts#L182
writeToEngineis referenced at lines 193 where it is passed an argument of typeany[], and at 196 where it is apssed an argument of typePacket. The inner function body ofwriteToEngineseems to expect to be passedPacket[]. Could you explain how this is working? If it just comes down to fixing type annotations, I would be happy to submit a PR for it once I understand the intended behaviour.To Reproduce
Socket.IO server version:
3.1.0The text was updated successfully, but these errors were encountered: