-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
no socket.io.js in lib #38
Comments
Actually, this is the best pattern. This way, you can require.paths.unshift('path/to/socket.io/lib') and require it as a "singleton": require('socket.io') This way, we also achieve npm compatibility without enforcing it. |
the example code you just mentioned does not work, specifically due to the issue I described. |
darrachequesne
added a commit
that referenced
this issue
Jul 4, 2024
darrachequesne
pushed a commit
that referenced
this issue
Jul 8, 2024
Use travis matrix for better test runs
This issue was closed.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
this breaks all existing users of this code and is a departure from the common pattern of putting your code in ./lib/
The text was updated successfully, but these errors were encountered: