Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sec-WebSocket-Location hardcoded to ws:// #40

Closed
jdub opened this issue Aug 25, 2010 · 3 comments
Closed

Sec-WebSocket-Location hardcoded to ws:// #40

jdub opened this issue Aug 25, 2010 · 3 comments

Comments

@jdub
Copy link

jdub commented Aug 25, 2010

Pretty simple hard-coding problem in lib/socket.io/transports/websocket.js, which was the only catch an otherwise flawless experience. :-) Will attach a patch.

@jdub
Copy link
Author

jdub commented Aug 27, 2010

I think I sent a pull request earlier, but here's the change which fixes this issue so everyene else can find and use it in the interim:

http://github.com/jdub/Socket.IO-node/commit/eadd5c95115695de3ebb0586c41a330a8f391019

@jdub
Copy link
Author

jdub commented Aug 28, 2010

Oh, that change was silly. This one is better. :-) Pull request submitted.

http://github.com/jdub/Socket.IO-node/commit/7db9a8ffe0555417e1e4abe7816812c76117c219

@rauchg
Copy link
Contributor

rauchg commented Aug 31, 2010

Updated client
Fixed WebSocket location header for ws/wss (Thanks @jdub, Closed by c023fae)

This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants