Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

setting Socket.IO to log: false causes total failure in Manager.js #491

Closed
perezd opened this issue Aug 29, 2011 · 1 comment
Closed

setting Socket.IO to log: false causes total failure in Manager.js #491

perezd opened this issue Aug 29, 2011 · 1 comment
Labels
bug Something isn't working

Comments

@perezd
Copy link

perezd commented Aug 29, 2011

L61 specifies that one can completely disable logging by setting the option log: false, upon doing so, Socket.IO will throw an exception about L116: this.log.info('socket.io started');

This is due to L140: if (this.disabled('log')) return;

this.log is undefined now, and undefined does not respond to info

@perezd
Copy link
Author

perezd commented Aug 29, 2011

current work around is set "log level": -1

@perezd perezd closed this as completed Aug 29, 2011
@perezd perezd reopened this Aug 29, 2011
@rauchg rauchg closed this as completed in fa1f50d Sep 3, 2011
darrachequesne pushed a commit that referenced this issue Jul 4, 2024
Don't try to support AMD loaders in socket.io
darrachequesne added a commit that referenced this issue Jul 8, 2024
By setting `handlePreflightRequest` to false, OPTIONS request are no
longer processed by engine.io. A function can also be provided.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants