Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bad headers in jsonp-polling, xhr-polling #58

Closed
SlNPacifist opened this issue Sep 28, 2010 · 1 comment
Closed

Bad headers in jsonp-polling, xhr-polling #58

SlNPacifist opened this issue Sep 28, 2010 · 1 comment

Comments

@SlNPacifist
Copy link
Contributor

jsonp-polling and xhr-polling require encoding parameter in Content-type header (some browsers decode data got with this methods with page's encoding)
Content-length gets corrupted if non-english symbols are sent because it requires number of bytes but string.length returns number of symbols in string.
This issue is fixed in http://github.com/SlNPacifist/Socket.IO-node branch
Buffer.byteLength is used, but Buffer became global object only in node.js v 0.1.103, so after merging with branch that will become the least version needed.

@rauchg
Copy link
Contributor

rauchg commented Jan 10, 2011

Fixed

This issue was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants