serve sourcemap for socket.io-client #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| debug('serve client sourcemap'); | ||
| res.setHeader('Content-Type', 'application/javascript'); |
There was a problem hiding this comment.
Also, according to this, it seems the content-type should rather be application/json.
|
sure. i will check what to do. |
|
@paradite thanks a lot, sorry for the delay (...) |
|
@paradite thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows server to serve the sourcemap of socket.io-client generated by webpack builder using
gulp buildtask.The corresponding PR for
socket.io-clientis socketio/socket.io-client#953Tested in Chrome and Firefox using a custom package of
socket.io-clientwith sourcemap file. It also catches the error when there is not sourcemap available insocket.io-client.Screenshots of how the generated source map looks in browsers:
