-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update the chat example #2675
Update the chat example #2675
Conversation
Why make it autonomous? Is it to make compilation easier for beginner devs or some other reason? Deffo a 👍 for the extra events though 😄 |
@MaffooBristol yes, it feels easier to run it as a standalone (to me). It may be a bit superfluous though. |
Hmm, maybe. But then is it not better for the examples to be entirely tied to the current source version rather than npm's version? Also it means that anyone editing the source can see whether it breaks the chat example, as a form of testing? Just not sure if I think it's the best idea personally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe in package.json
It's better to change start command to node index.js
to specify file name.
The remaining parts are good!!!
I'm getting a 'cannot find module ../..' when trying to follow this example. |
@KevinHoughton the
You can also replace it by |
npm install && npm start
)