Small addition to the Express Readme Part #2846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I used the express setup with my latest project and stumbled into an error, that was hard to fix, because it was so small and crucial. I accidently called `app.listen(PORT)` instead of `server.listen(PORT)` This basically leads to working Express functionality and routes, but the `/socket.io` route will not be present and thus the GET request for any client willing to connect gets a 404. I hope this small comment may save another one the four hours I spent on tracing my mistake.
|
Thanks for the contribution! |
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
This was referenced Nov 28, 2023
This was referenced Nov 29, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
I used the express setup with my latest project and stumbled into an error, that was hard to fix, because it was so small and crucial.
I accidently called
app.listen(PORT)instead ofserver.listen(PORT)This basically leads to working Express functionality and routes, but the
/socket.ioroute will not be present and thus the GET request for any client willing to connect gets a 404.New behaviour
I hope this small comment may save another one the four hours I spent on tracing my mistake.
Other information (e.g. related issues)