Adding rail guard to dispatch's event param #3140
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
When event packet received by
onevent
doesn't contain a valid array as the value of thedata
property, the subsequent call to dispatch will cause aTypeError
, because theapply
call onemit
would expect the 2nd parameter to be an array type.New behaviour
Now if event packet's
data
property is not already an array, we will convert it to an array before passing it to theapply
call, to avoid theTypeError
exception on rare occurrence of the problem as raised in issue #3139.Other information (e.g. related issues)
There seem to be quite a few other places that would use a similar array type check in
socket.js
, but would rather hold off on updating all these places until further reporting of theTypeError
exceptions.