Skip to content

fix NodeNext module resolution compatibility #4625

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix NodeNext module resolution compatibility #4625

wants to merge 1 commit into from

Conversation

igorls
Copy link
Contributor

@igorls igorls commented Feb 9, 2023 •
edited
Loading

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behavior

Types are not found when typescript moduleResolution is set to NodeNext, issue #4621

New behavior

Works normally with NodeNext

Other information (e.g. related issues)

Must be merged together with the engine.io PR socketio/engine.io#669

@igorls igorls mentioned this pull request Feb 9, 2023
Merged
5 tasks
darrachequesne pushed a commit that referenced this pull request Feb 20, 2023
@igorls @darrachequesne
fix(types): fix nodenext module resolution compatibility (#4625)
d0b22c6 
The import added in [1] was invalid, because it used an non-exported
class.

Related: #4621

[1]: d4a9b2c
@darrachequesne
Copy link
Member

Merged as d0b22c6. Thanks!

haneenmahd pushed a commit to haneenmahd/socket.io that referenced this pull request Apr 15, 2023
@igorls @haneenmahd
fix(types): fix nodenext module resolution compatibility (socketio#4625)
4a4a03f 
The import added in [1] was invalid, because it used an non-exported
class.

Related: socketio#4621

[1]: socketio@d4a9b2c
dzad pushed a commit to dzad/socket.io that referenced this pull request May 29, 2023
@igorls @darrachequesne
fix(types): fix nodenext module resolution compatibility (socketio#4625)
2aa6636 
The import added in [1] was invalid, because it used an non-exported
class.

Related: socketio#4621

[1]: socketio@6652a3f
@X-oss-byte X-oss-byte mentioned this pull request Aug 11, 2023
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@WilliamUK17 WilliamUK17 mentioned this pull request May 24, 2024
Open
@dIwnsgml dIwnsgml mentioned this pull request May 24, 2024
Open
@NOUIY NOUIY mentioned this pull request May 24, 2024
Open
@nouhaila49 nouhaila49 mentioned this pull request May 24, 2024
Open
@charley-geoffroy charley-geoffroy mentioned this pull request May 25, 2024
Open
@seahare-slug seahare-slug mentioned this pull request May 30, 2024
Open
@dIwnsgml dIwnsgml mentioned this pull request May 31, 2024
Open
@charley-geoffroy charley-geoffroy mentioned this pull request May 31, 2024
Open
@NOUIY NOUIY mentioned this pull request Jun 1, 2024
Open
This was referenced Jun 2, 2024
Open
Open
Open
Open
@nejidevelops nejidevelops mentioned this pull request Jun 7, 2024
Open
@Mykhailo-Sichkaruk Mykhailo-Sichkaruk mentioned this pull request Jun 13, 2024
Closed
@NOUIY NOUIY mentioned this pull request Jun 18, 2024
Open
@WilliamUK17 WilliamUK17 mentioned this pull request Jun 18, 2024
Open
@dIwnsgml dIwnsgml mentioned this pull request Jun 19, 2024
Open
@charley-geoffroy charley-geoffroy mentioned this pull request Jun 20, 2024
Open
@dIwnsgml dIwnsgml mentioned this pull request Jun 20, 2024
Open
@WilliamUK17 WilliamUK17 mentioned this pull request Jun 20, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Jun 21, 2024
Open
@dIwnsgml dIwnsgml mentioned this pull request Jun 21, 2024
Open
@nay0101 nay0101 mentioned this pull request Jun 23, 2024
Closed
@NOUIY NOUIY mentioned this pull request Jul 12, 2024
Open
@dIwnsgml dIwnsgml mentioned this pull request Jul 13, 2024
Open
@WilliamUK17 WilliamUK17 mentioned this pull request Jul 13, 2024
Open
@charley-geoffroy charley-geoffroy mentioned this pull request Jul 13, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@misbahkhalilaz misbahkhalilaz misbahkhalilaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igorls @darrachequesne @misbahkhalilaz