-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix docker build pipeline #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Like @ogrisel suggests, I think it is good to have a small comment for this version specifier.
I'm still not building it locally There's something wrong with dpnp build that requires further debug |
d817dc0
to
a102937
Compare
Latest commits both address latest issues and bump to latest releases. I'd like to bump aggressively to latest commits of master branch for |
Fixes #94 |
Not yet functional, see IntelPython/dpctl#1190 However the conda install works. |
Last push finally contains a Dockerfile for an image that builds and works. But it's not very useable, since it contains a broken dependency tree, pip resolver will try to fix it whevener it can (e.g when building scikit-learn...), and the automated resolution fix just breaks the runtime. IMO the docker environment can't be updated until IntelPython/dpctl#1190 is fixed. The solution of pinning everything to I've checked that the performance for KMeans remains good both locally and on edge cloud with the version combinations I need a up-to-date environment without our patches on loading |
Or if the the |
Installers work again with 2023.2.0 release, but there's a regression in latest |
Things work on my local environment, I'll merge so that the automated build pipeline can resume, and the conda install instruction are fixed. |
Numba 0.57 compatibility issues are already reported upstream see IntelPython/numba-dpex#1000