fix: clean

sofastack · Feb 27, 2023 · 6b0138d · 6b0138d
1 parent ccb18d2
commit 6b0138d
Showing 1 changed file with 26 additions and 29 deletions.
diff --git a/...va/com/alipay/sofa/rpc/codec/sofahessian/serialize/SofaResponseHessianSerializerTest.java b/...va/com/alipay/sofa/rpc/codec/sofahessian/serialize/SofaResponseHessianSerializerTest.java
@@ -26,6 +26,7 @@
 import com.caucho.hessian.io.Hessian2Output;
 import org.junit.After;
 import org.junit.Assert;
+import org.junit.Before;
 import org.junit.Test;
 
 import java.io.ByteArrayOutputStream;
@@ -39,35 +40,35 @@
  */
 public class SofaResponseHessianSerializerTest {
 
+    @Before
     @After
-    public void tearDown() {
-        GenericThrowExceptionUtil.setGenericThrowException(false);
+    public void clean() {
         GenericThrowExceptionUtil.clearCacheDeserializerMap();
     }
 
-    //    @Test
-    //    public void testCustomThrowableDeserializer() throws Exception {
-    //        GenericMultipleClassLoaderSofaSerializerFactory factory = new GenericMultipleClassLoaderSofaSerializerFactory();
-    //        SofaResponseHessianSerializer serializer = new SofaResponseHessianSerializer(null, factory);
-    //
-    //        ByteArrayOutputStream bsOut = new ByteArrayOutputStream();
-    //        Hessian2Output hessian2Output = new Hessian2Output(bsOut);
-    //        hessian2Output.setSerializerFactory(factory);
-    //
-    //        SofaResponse sofaResponse = new SofaResponse();
-    //        MockError mockError = new MockError("MockError");
-    //        sofaResponse.setAppResponse(mockError);
-    //        hessian2Output.writeObject(sofaResponse);
-    //        hessian2Output.flush();
-    //
-    //        ByteArrayWrapperByteBuf bsIn = new ByteArrayWrapperByteBuf(bsOut.toByteArray());
-    //        Map<String, String> ctx = new HashMap<>();
-    //        ctx.put(RemotingConstants.HEAD_GENERIC_TYPE, "2");
-    //        SofaResponse sofaResponse2 = new SofaResponse();
-    //        serializer.decodeObjectByTemplate(bsIn, ctx, sofaResponse2);
-    //        Assert.assertTrue(sofaResponse2.getAppResponse() instanceof GenericObject);
-    //        Assert.assertEquals("MockError", ((GenericObject) sofaResponse2.getAppResponse()).getField("detailMessage"));
-    //    }
+    @Test
+    public void testCustomThrowableDeserializer() throws Exception {
+        GenericMultipleClassLoaderSofaSerializerFactory factory = new GenericMultipleClassLoaderSofaSerializerFactory();
+        SofaResponseHessianSerializer serializer = new SofaResponseHessianSerializer(null, factory);
+
+        ByteArrayOutputStream bsOut = new ByteArrayOutputStream();
+        Hessian2Output hessian2Output = new Hessian2Output(bsOut);
+        hessian2Output.setSerializerFactory(factory);
+
+        SofaResponse sofaResponse = new SofaResponse();
+        MockError mockError = new MockError("MockError");
+        sofaResponse.setAppResponse(mockError);
+        hessian2Output.writeObject(sofaResponse);
+        hessian2Output.flush();
+
+        ByteArrayWrapperByteBuf bsIn = new ByteArrayWrapperByteBuf(bsOut.toByteArray());
+        Map<String, String> ctx = new HashMap<>();
+        ctx.put(RemotingConstants.HEAD_GENERIC_TYPE, "2");
+        SofaResponse sofaResponse2 = new SofaResponse();
+        serializer.decodeObjectByTemplate(bsIn, ctx, sofaResponse2);
+        Assert.assertTrue(sofaResponse2.getAppResponse() instanceof GenericObject);
+        Assert.assertEquals("MockError", ((GenericObject) sofaResponse2.getAppResponse()).getField("detailMessage"));
+    }
 
     @Test
     public void testCustomThrowableDeserializerEnabled() throws Exception {
@@ -93,8 +94,6 @@ public void testCustomThrowableDeserializerEnabled() throws Exception {
             serializer.decodeObjectByTemplate(bsIn, ctx, sofaResponse2);
             Assert.assertTrue(sofaResponse2.getAppResponse() instanceof MockError);
             Assert.assertEquals("MockError", ((MockError) sofaResponse2.getAppResponse()).getMessage());
-        } catch (Throwable e) {
-            e.printStackTrace();
         } finally {
             GenericThrowExceptionUtil.setGenericThrowException(false);
             GenericThrowExceptionUtil.clearCacheDeserializerMap();
@@ -124,8 +123,6 @@ public void testCustomThrowableDeserializerEnabledForIncompatible() throws Excep
             Assert.assertTrue(((RuntimeException) sofaResponse2.getAppResponse()).getMessage().startsWith(
                     "occur business exception, but type=com.alipay.sofa.rpc.codec.sofahessian.mock.DeprecatedMockError class is not "
                             + "found, error: "));
-        } catch (Throwable e) {
-          e.printStackTrace();
         } finally {
             GenericThrowExceptionUtil.setGenericThrowException(false);
             GenericThrowExceptionUtil.clearCacheDeserializerMap();