-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix ProviderConfig setTimeout generic error #1143
fix ProviderConfig setTimeout generic error #1143
Conversation
Hi @wind-hx, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
@wind-hx Could you help fix similar problems in |
bug fixes |
Codecov Report
@@ Coverage Diff @@
## master #1143 +/- ##
============================================
- Coverage 71.07% 70.96% -0.12%
+ Complexity 833 828 -5
============================================
Files 405 405
Lines 17100 17108 +8
Branches 2669 2670 +1
============================================
- Hits 12154 12140 -14
- Misses 3561 3588 +27
+ Partials 1385 1380 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The error message in the integration tests is weird. |
I will check this problem. |
@wind-hx
|
Motivation:
The result of calling setTimeout has no generic