Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ut/bootstrap api #1163

Merged
merged 4 commits into from
Mar 28, 2022
Merged

Ut/bootstrap api #1163

merged 4 commits into from
Mar 28, 2022

Conversation

OrezzerO
Copy link
Contributor

Motivation:

Add some test case for RPC config classes

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #1163 (f2c210b) into master (956a546) will increase coverage by 0.38%.
The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1163      +/-   ##
============================================
+ Coverage     71.06%   71.45%   +0.38%     
- Complexity      828      829       +1     
============================================
  Files           406      407       +1     
  Lines         17150    17160      +10     
  Branches       2671     2673       +2     
============================================
+ Hits          12187    12261      +74     
+ Misses         3591     3536      -55     
+ Partials       1372     1363       -9     
Impacted Files Coverage Δ
...va/com/alipay/sofa/rpc/common/utils/TestUtils.java 90.00% <90.00%> (ø)
...java/com/alipay/sofa/rpc/module/LookoutModule.java 52.38% <0.00%> (-33.34%) ⬇️
...n/java/com/alipay/sofa/rpc/log/TimeWaitLogger.java 80.00% <0.00%> (-4.00%) ⬇️
...a/com/alipay/sofa/rpc/common/utils/ClassUtils.java 78.23% <0.00%> (-2.05%) ⬇️
...ay/sofa/rpc/client/AllConnectConnectionHolder.java 60.51% <0.00%> (-0.26%) ⬇️
...lipay/sofa/rpc/message/AbstractResponseFuture.java 57.01% <0.00%> (+0.87%) ⬆️
...ava/com/alipay/sofa/rpc/config/ProviderConfig.java 55.00% <0.00%> (+1.00%) ⬆️
...com/alipay/sofa/rpc/context/RpcRuntimeContext.java 90.12% <0.00%> (+1.23%) ⬆️
...pay/sofa/rpc/transport/ClientTransportFactory.java 78.46% <0.00%> (+1.53%) ⬆️
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 86.79% <0.00%> (+1.88%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956a546...f2c210b. Read the comment docs.

@OrezzerO OrezzerO requested a review from JervyShi February 9, 2022 13:54
Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JervyShi JervyShi merged commit 9c56f7f into sofastack:master Mar 28, 2022
@EvenLjj EvenLjj added this to the 5.8.4 milestone Apr 24, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants