Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix-destroy方法的错误代码 #1164

Merged
merged 3 commits into from
Feb 14, 2022
Merged

fix-destroy方法的错误代码 #1164

merged 3 commits into from
Feb 14, 2022

Conversation

yuzd
Copy link
Contributor

@yuzd yuzd commented Jan 28, 2022

Motivation:

hook应该先preDestory

Modification:

虽然这个不会出bug,但是为了严谨和高质量

虽然这个不会出bug,但是为了严谨高质量还是得改下。
@sofastack-bot
Copy link

sofastack-bot bot commented Jan 28, 2022

Hi @yuzd, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:no Need sign CLA First-time contributor First-time contributor size/XS labels Jan 28, 2022
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #1164 (1c69f94) into master (443b1c6) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1164      +/-   ##
============================================
+ Coverage     71.06%   71.17%   +0.11%     
+ Complexity      826      825       -1     
============================================
  Files           407      407              
  Lines         17180    17180              
  Branches       2679     2679              
============================================
+ Hits          12209    12228      +19     
+ Misses         3596     3575      -21     
- Partials       1375     1377       +2     
Impacted Files Coverage Δ
...va/com/alipay/sofa/rpc/client/AbstractCluster.java 70.68% <100.00%> (+1.04%) ⬆️
...n/java/com/alipay/sofa/rpc/log/TimeWaitLogger.java 80.00% <0.00%> (-4.00%) ⬇️
...ofa/rpc/registry/zk/ZookeeperProviderObserver.java 72.50% <0.00%> (-2.50%) ⬇️
...pay/sofa/rpc/transport/ClientTransportFactory.java 76.92% <0.00%> (-1.54%) ⬇️
.../com/alipay/sofa/rpc/context/RpcInvokeContext.java 81.48% <0.00%> (-0.93%) ⬇️
...lipay/sofa/rpc/registry/consul/ConsulRegistry.java 47.25% <0.00%> (-0.55%) ⬇️
...ipay/sofa/rpc/tracer/sofatracer/RpcSofaTracer.java 91.06% <0.00%> (+0.74%) ⬆️
...om/alipay/sofa/rpc/server/triple/TripleServer.java 75.13% <0.00%> (+1.10%) ⬆️
...com/alipay/sofa/rpc/context/RpcRuntimeContext.java 88.88% <0.00%> (+1.23%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 443b1c6...1c69f94. Read the comment docs.

@yuzd
Copy link
Contributor Author

yuzd commented Jan 28, 2022

@leizhiyuan @JervyShi @EvenLjj pls review this PR, thanks

@sofastack-bot sofastack-bot bot added cla:yes CLA is ok size/M and removed cla:no Need sign CLA size/XS labels Feb 10, 2022
@yuzd yuzd requested a review from JervyShi February 12, 2022 11:28
Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj merged commit ddccf7a into sofastack:master Feb 14, 2022
@EvenLjj EvenLjj added this to the 5.8.3 milestone Mar 2, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working cla:yes CLA is ok First-time contributor First-time contributor size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants