Add debug log of the measurement result details. #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the serializer of hessian and protobuf. (sofastack#116)
NeGnail
changed the title
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
============================================
+ Coverage 65.01% 65.14% +0.12%
- Complexity 646 652 +6
============================================
Files 271 271
Lines 11587 11618 +31
Branches 1953 1957 +4
============================================
+ Hits 7533 7568 +35
+ Misses 3082 3080 -2
+ Partials 972 970 -2
Continue to review full report at Codecov.
|
ujjboy
requested changes
May 15, 2018
| List<InvocationStat> stats = measureModel.getInvocationStats(); | ||
| List<MeasureResultDetail> details = measureResult.getAllMeasureResultDetails(); | ||
|
|
||
| if (!LOGGER.isInfoEnabled(appName)) { |
| info.append(","); | ||
| } | ||
| if (stats.size() > 0) { | ||
| info = new StringBuilder(info.substring(0, info.lastIndexOf(","))); |
There was a problem hiding this comment.
这个是要删最后一个字符吗？ 直接 info.deleteCharAt(info.length()-1)
|
|
||
| public static void main(String[] args) { | ||
| new ServiceHorizontalMeasureStrategy().logMeasureResult(null, 0, 0, 0, 0); | ||
| } |
ujjboy
approved these changes
May 15, 2018
ujjboy
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Print the measurement result details for each time window.For example：
Modification:
add method ‘com.alipay.sofa.rpc.client.aft.impl.ServiceHorizontalMeasureStrategy#logMeasureResult’
Result:
Fixes #109 .