Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Post ServerEndHandleEvent after server return when using async chain invoke. #123

Merged
merged 1 commit into from
May 15, 2018

Conversation

ujjboy
Copy link
Member

@ujjboy ujjboy commented May 15, 2018

Motivation:

Post ServerEndHandleEvent after server return when using async chain invoke.

Result:

Fixes #122 in v5.3.x.

@ujjboy ujjboy added the bug Something isn't working label May 15, 2018
@ujjboy ujjboy added this to the 5.3.3 milestone May 15, 2018
@codecov-io
Copy link

Codecov Report

Merging #123 into 5.3 will decrease coverage by 0.04%.
The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##                5.3     #123      +/-   ##
============================================
- Coverage     63.53%   63.48%   -0.05%     
+ Complexity      582      581       -1     
============================================
  Files           263      263              
  Lines         11247    11251       +4     
  Branches       1874     1876       +2     
============================================
- Hits           7146     7143       -3     
- Misses         3128     3136       +8     
+ Partials        973      972       -1
Impacted Files Coverage Δ Complexity Δ
...rpc/message/bolt/BoltSendableResponseCallback.java 43.58% <0%> (-2.36%) 5 <0> (ø)
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 64.28% <57.14%> (-0.24%) 20 <0> (ø)
...m/alipay/sofa/rpc/module/FaultToleranceModule.java 66.66% <0%> (-26.67%) 4% <0%> (-1%)
...lipay/sofa/rpc/codec/antpb/ProtobufSerializer.java 47.82% <0%> (-2.9%) 9% <0%> (ø)
...ay/sofa/rpc/client/AllConnectConnectionHolder.java 52.51% <0%> (-0.28%) 0% <0%> (ø)
...pay/sofa/rpc/transport/ClientTransportFactory.java 65.15% <0%> (+4.54%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d7a77a...dc996f5. Read the comment docs.

@ujjboy ujjboy merged commit 49acbf4 into sofastack:5.3 May 15, 2018
@ujjboy ujjboy deleted the fix_issue_122 branch May 15, 2018 15:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants