Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix/triple trace log service without version #1281

Merged
merged 3 commits into from
Dec 9, 2022

Conversation

EvenLjj
Copy link
Collaborator

@EvenLjj EvenLjj commented Nov 26, 2022

Fix triple client and server log uniqueName without version info.

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes CLA is ok size/L labels Nov 26, 2022
@EvenLjj EvenLjj requested a review from OrezzerO December 5, 2022 12:45
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #1281 (29423e9) into master (2a0556d) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1281      +/-   ##
============================================
+ Coverage     71.93%   71.99%   +0.05%     
- Complexity      780      784       +4     
============================================
  Files           413      414       +1     
  Lines         17555    17565      +10     
  Branches       2739     2740       +1     
============================================
+ Hits          12629    12646      +17     
+ Misses         3532     3525       -7     
  Partials       1394     1394              
Impacted Files Coverage Δ
...rpc/bootstrap/triple/TripleClientProxyInvoker.java 100.00% <100.00%> (ø)
.../rpc/bootstrap/triple/TripleConsumerBootstrap.java 100.00% <100.00%> (ø)
...pay/sofa/rpc/config/ConfigUniqueNameGenerator.java 94.44% <100.00%> (+0.69%) ⬆️
...ofa/rpc/tracer/sofatracer/TripleTracerAdapter.java 61.31% <100.00%> (+0.57%) ⬆️
...ansport/bolt/ReuseBoltClientConnectionManager.java 65.21% <0.00%> (-7.25%) ⬇️
...com/alipay/sofa/rpc/context/RpcRuntimeContext.java 88.88% <0.00%> (-1.24%) ⬇️
...va/com/alipay/sofa/rpc/client/AbstractCluster.java 71.54% <0.00%> (+0.52%) ⬆️
.../com/alipay/sofa/rpc/context/RpcInvokeContext.java 82.40% <0.00%> (+0.92%) ⬆️
...a/com/alipay/sofa/rpc/common/utils/ClassUtils.java 80.27% <0.00%> (+2.04%) ⬆️
...java/com/alipay/sofa/rpc/module/LookoutModule.java 85.71% <0.00%> (+33.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lo1nt Lo1nt added this to the 5.9.1 milestone Dec 7, 2022
@EvenLjj EvenLjj merged commit 7931102 into master Dec 9, 2022
@nobodyiam nobodyiam deleted the fix/triple_trace_log_service_error branch December 20, 2022 01:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working cla:yes CLA is ok size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants