-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix#1254#1305 bug on JSON serialization and deserialization #1306
Conversation
Hi @gofow, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
|
@EvenLjj Thank you! Actually I'm feeling confused about the error, and I have done with the format. |
core/common/src/test/java/com/alipay/sofa/rpc/common/json/JSONTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #1306 +/- ##
============================================
- Coverage 71.97% 71.96% -0.02%
Complexity 783 783
============================================
Files 415 415
Lines 17651 17651
Branches 2753 2753
============================================
- Hits 12705 12703 -2
- Misses 3538 3546 +8
+ Partials 1408 1402 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Motivation:
Fix#1254#1305 bug on JSON serialization and deserialization
Modification: