-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Integrate with sofa-tracer for support opentracing. #131
Conversation
|
||
try { | ||
invoke(); | ||
Thread.sleep(5000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个sleep是为了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ujjboy 为了等一些 callback 回来.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯 那就在 callback 调完之后 用 CountdownLatch 等吧,这里可以不用等了。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个暂时不改了.看了一下,还有 oneway 等的处理.我之后看看怎么优化下
/*** | ||
* 弹性数据位 | ||
*/ | ||
public static final String ELASTIC_ID = "elastic.id"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我在想字段这几个要不要删掉?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以,我先删除,也没人用到现在.
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
============================================
+ Coverage 66.39% 68.09% +1.69%
+ Complexity 756 729 -27
============================================
Files 280 302 +22
Lines 11897 12640 +743
Branches 1981 2077 +96
============================================
+ Hits 7899 8607 +708
+ Misses 3011 2988 -23
- Partials 987 1045 +58
Continue to review full report at Codecov.
|
|
||
try { | ||
invoke(); | ||
Thread.sleep(5000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯 那就在 callback 调完之后 用 CountdownLatch 等吧,这里可以不用等了。
@Test | ||
public void testProviderServiceStats() throws InterruptedException { | ||
|
||
Metric metric = fetchWithName("rpc.provider.service.stats"); | ||
|
||
for (Tag tag : metric.id().tags()) { | ||
if (tag.key() == "method") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里要改掉吧。
Motivation:
integration with sofa tracer
Modification:
based on @ujjboy 's tracer integration, add stat info print.
in order to test .I add
com.alipay.sofa.rpc.tracer.sofatracer.factory.MemoryReporterImpl
, annotationed by @justfortestResult:
we will have stat infos in rpc-client-stat.log and rpc-server-stat.log as below.
service,method,localapp,remoteapp,count,time,success.