Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: bolt swagger class not found error #1310

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

Lo1nt
Copy link
Collaborator

@Lo1nt Lo1nt commented Feb 22, 2023

Motivation:

Current swagger-core 1.5.8 depends on jackson-databind 2.9.x.

While the whole project use jackson-databind 2.13.x, and there is incompatible changes from 2.9.x to 2.13.x which introduce bugs applying swagger-core.

Modification:

let objectweb asm to be included
upgrade io.swagger series to 1.6.9

Result:

Fixes #1300 sofastack/sofa-boot#1061

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes CLA is ok size/XS labels Feb 22, 2023
@Lo1nt Lo1nt added this to the 5.9.2 milestone Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #1310 (e2e4300) into master (75bc1ff) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1310      +/-   ##
============================================
+ Coverage     71.97%   72.01%   +0.03%     
- Complexity      783      785       +2     
============================================
  Files           415      415              
  Lines         17651    17651              
  Branches       2753     2753              
============================================
+ Hits          12705    12711       +6     
+ Misses         3538     3537       -1     
+ Partials       1408     1403       -5     
Impacted Files Coverage Δ
.../main/java/com/alipay/sofa/rpc/common/Version.java 100.00% <ø> (ø)
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 84.90% <0.00%> (-1.89%) ⬇️
.../com/alipay/sofa/rpc/context/RpcInvokeContext.java 82.40% <0.00%> (+0.92%) ⬆️
...pay/sofa/rpc/transport/ClientTransportFactory.java 78.46% <0.00%> (+1.53%) ⬆️
.../alipay/sofa/rpc/metrics/lookout/RpcLookoutId.java 88.88% <0.00%> (+1.58%) ⬆️
...ofa/rpc/registry/zk/ZookeeperProviderObserver.java 75.00% <0.00%> (+2.50%) ⬆️
...ansport/bolt/ReuseBoltClientConnectionManager.java 72.46% <0.00%> (+4.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit e5c19a3 into sofastack:master Mar 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working cla:yes CLA is ok size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sofa-rpc-all 中缺少 asm 的依赖信息导致 swagger 的能力没法使用
3 participants