Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: virtual thread name #1393

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

Lo1nt
Copy link
Collaborator

@Lo1nt Lo1nt commented Jan 19, 2024

Motivation:

print thread type with thread name

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@sofastack-cla sofastack-cla bot added cla:yes CLA is ok size/M labels Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (9faa8b8) 72.04% compared to head (3cf70f7) 72.04%.
Report is 4 commits behind head on master.

Files Patch % Lines
...va/com/alipay/sofa/rpc/server/bolt/BoltServer.java 53.06% 16 Missing and 7 partials ⚠️
.../sofa/rpc/dynamic/DynamicConfigManagerFactory.java 0.00% 6 Missing ⚠️
...ava/com/alipay/sofa/rpc/server/UserThreadPool.java 75.00% 2 Missing and 2 partials ⚠️
...ipay/sofa/rpc/codec/jackson/JacksonSerializer.java 93.54% 0 Missing and 2 partials ⚠️
...ipay/sofa/rpc/codec/jackson/JacksonConfigKeys.java 88.88% 1 Missing ⚠️
...sofa/rpc/common/threadpool/ThreadPoolConstant.java 0.00% 1 Missing ⚠️
...threadpool/extension/VirtualThreadPoolFactory.java 90.90% 1 Missing ⚠️
.../alipay/sofa/rpc/server/UserVirtualThreadPool.java 83.33% 1 Missing ⚠️
...a/com/alipay/sofa/rpc/event/LookoutSubscriber.java 66.66% 0 Missing and 1 partial ⚠️
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1393      +/-   ##
============================================
- Coverage     72.04%   72.04%   -0.01%     
- Complexity      785      791       +6     
============================================
  Files           417      422       +5     
  Lines         17709    17815     +106     
  Branches       2760     2770      +10     
============================================
+ Hits          12759    12834      +75     
- Misses         3546     3566      +20     
- Partials       1404     1415      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@chuailiwu chuailiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Lo1nt Lo1nt merged commit ff333d3 into sofastack:master Jan 22, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants