Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix lost interface name and method name in tracer when no such method… #1397

Merged

Conversation

EvenLjj
Copy link
Collaborator

@EvenLjj EvenLjj commented Feb 27, 2024

fix lost interface name and method name in tracer when no such method case.

@sofastack-cla sofastack-cla bot added bug Something isn't working question Further information is requested cla:yes CLA is ok size/L labels Feb 27, 2024
@EvenLjj EvenLjj force-pushed the fix/tracer_lost_in_nosuch_method_case branch from 4610a11 to 2e852c4 Compare February 28, 2024 03:29
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.05%. Comparing base (357fdf0) to head (2e852c4).

Files Patch % Lines
...fa/rpc/filter/sofatracer/ProviderTracerFilter.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1397   +/-   ##
=========================================
  Coverage     72.04%   72.05%           
- Complexity      795      796    +1     
=========================================
  Files           422      422           
  Lines         17815    17813    -2     
  Branches       2770     2769    -1     
=========================================
  Hits          12835    12835           
+ Misses         3570     3567    -3     
- Partials       1410     1411    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@leslieSll leslieSll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj merged commit 70f16f3 into sofastack:master Mar 25, 2024
5 checks passed
@EvenLjj EvenLjj added this to the 5.13.0 milestone Apr 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working cla:yes CLA is ok question Further information is requested size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants