Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix reconnect of bolt/rest/h2c. #180

Merged
merged 3 commits into from
Jun 14, 2018
Merged

Conversation

ujjboy
Copy link
Member

@ujjboy ujjboy commented Jun 14, 2018

Modification:

  • Remove dead connection from manager before reconnect.
  • Fix reconnect behaviour of h2c and rest.

PS: Because of bolt-1.4.2 don't release IOEventGroup when stop(), so I can't write unit test case.

Result:

Fixes #178

@ujjboy ujjboy added the bug Something isn't working label Jun 14, 2018
@ujjboy ujjboy added this to the 5.4.1 milestone Jun 14, 2018
@codecov-io
Copy link

codecov-io commented Jun 14, 2018

Codecov Report

Merging #180 into master will increase coverage by 0.34%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #180      +/-   ##
============================================
+ Coverage     68.58%   68.92%   +0.34%     
- Complexity      947      952       +5     
============================================
  Files           340      341       +1     
  Lines         14163    14183      +20     
  Branches       2274     2276       +2     
============================================
+ Hits           9714     9776      +62     
+ Misses         3287     3243      -44     
- Partials       1162     1164       +2
Impacted Files Coverage Δ Complexity Δ
...pay/sofa/rpc/server/rest/SofaNettyJaxrsServer.java 55.23% <100%> (+0.43%) 0 <0> (ø) ⬇️
...alipay/sofa/rpc/server/http/HttpServerHandler.java 70% <100%> (ø) 11 <1> (+1) ⬆️
...va/com/alipay/sofa/rpc/server/rest/RestServer.java 63.72% <100%> (ø) 0 <0> (ø) ⬇️
.../main/java/com/alipay/sofa/rpc/test/TestUtils.java 58.33% <58.33%> (ø) 0 <0> (?)
...c/transport/http/AbstractHttp2ClientTransport.java 78.04% <66.66%> (-0.22%) 29 <1> (+2)
...lipay/sofa/rpc/server/http/AbstractHttpServer.java 71.02% <85.71%> (+1.12%) 15 <0> (ø) ⬇️
.../main/java/com/alipay/sofa/rpc/tracer/Tracers.java 39.74% <0%> (-2.57%) 0% <0%> (ø)
...va/com/alipay/sofa/rpc/server/bolt/BoltServer.java 73.86% <0%> (-1.14%) 23% <0%> (-1%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1232c7...047db1e. Read the comment docs.

@ujjboy ujjboy merged commit 53569c0 into sofastack:master Jun 14, 2018
@ujjboy ujjboy changed the title Remove dead connection from manager before reconnect. Fix reconnect of bolt/rest/h2c. Jun 14, 2018
@ujjboy ujjboy deleted the fix_issue_178 branch June 14, 2018 13:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants