Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Set interface name to SofaRequest when deserialize request. #70

Merged
merged 1 commit into from
Apr 28, 2018

Conversation

ujjboy
Copy link
Member

@ujjboy ujjboy commented Apr 28, 2018

Fix #40

@ujjboy ujjboy added the enhancement New feature or request label Apr 28, 2018
@ujjboy ujjboy added this to the 5.4.0 milestone Apr 28, 2018
@ujjboy ujjboy self-assigned this Apr 28, 2018
@codecov-io
Copy link

codecov-io commented Apr 28, 2018

Codecov Report

Merging #70 into master will increase coverage by 0.02%.
The diff coverage is 41.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #70      +/-   ##
============================================
+ Coverage     63.53%   63.55%   +0.02%     
- Complexity      592      594       +2     
============================================
  Files           263      263              
  Lines         11278    11294      +16     
  Branches       1884     1887       +3     
============================================
+ Hits           7165     7178      +13     
- Misses         3143     3147       +4     
+ Partials        970      969       -1
Impacted Files Coverage Δ Complexity Δ
.../com/alipay/sofa/rpc/core/request/RequestBase.java 83.33% <ø> (ø) 0 <0> (ø) ⬇️
.../com/alipay/sofa/rpc/core/request/SofaRequest.java 71.73% <ø> (ø) 0 <0> (ø) ⬇️
...pay/sofa/rpc/config/ConfigUniqueNameGenerator.java 91.66% <100%> (+29.16%) 0 <0> (ø) ⬇️
...ipay/sofa/rpc/codec/bolt/SofaRpcSerialization.java 46.36% <23.07%> (-0.67%) 36 <0> (ø)
...pay/sofa/rpc/transport/ClientTransportFactory.java 63.63% <0%> (-1.52%) 0% <0%> (ø)
...com/alipay/sofa/rpc/context/RpcRuntimeContext.java 79.01% <0%> (-1.24%) 0% <0%> (ø)
...n/java/com/alipay/sofa/rpc/filter/FilterChain.java 65.81% <0%> (+0.85%) 0% <0%> (ø) ⬇️
...ent/aft/impl/ServiceHorizontalMeasureStrategy.java 86.53% <0%> (+2.88%) 23% <0%> (+1%) ⬆️
...pay/sofa/rpc/client/aft/InvocationStatFactory.java 87.8% <0%> (+4.87%) 16% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f10ee0e...48a6572. Read the comment docs.

@ujjboy ujjboy merged commit 238c4e3 into sofastack:master Apr 28, 2018
@ujjboy ujjboy deleted the fix_issue_40 branch April 29, 2018 02:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants