Mark NoFinalize as unsafe and document it.
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltratt
reviewed
Aug 9, 2021
library/core/src/gc.rs
Outdated
| /// Unsafe because this should be used with care. Preventing drop from | ||
| /// running can lead to surprising behaviour. In particular, this will also | ||
| /// prevent the finalization of all component types of T. | ||
| pub unsafe fn new(value: T) -> NonFinalizable<T> { |
There was a problem hiding this comment.
Just to be awkward, since this is ManuallyDrop in disguise, I think it's OK for this to not be marked as unsafe (ManuallyDrop::new is not unsafe). I don't feel strongly about that though!
|
I notice that the PR has conflicts? Maybe push a merge commit to master in here? |
|
@jacob-hughes Where are we with this one? |
I'm not sure what happened there which made my local branch so out of sync with the softdev repo, anyway I've added a merge commit which can be squashed away later. |
|
Please squash. |
jacob-hughes
force-pushed
the
fix_no_finalize_semantics
branch
from
5838776 to
d62c55b
Compare
The `NoFinalize` trait prevents a type `T` from being finalized when its passed to `Gc<T>`.
jacob-hughes
force-pushed
the
fix_no_finalize_semantics
branch
from
d62c55b to
5ebb0fa
Compare
|
Squashed |
|
bors r+ |
|
Build succeeded: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NoFinalizetrait prevents a typeTfrom being finalized when itspassed to
Gc<T>.Now that we've settled on a preferred semantics for
NoFinalize, the implementation here was already correct. I've tweaked it to be unsafe, added a couple more tests, and documented it.