Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

resolves On Android devices "getPointAtLength" function returns incorrect values #1727

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

insbodhi
Copy link
Contributor

@insbodhi insbodhi commented Mar 22, 2022

Summary

This pull request resolves #1721. While computing the point at length I have passed in the scaled value for path length.

Compatibility

OS Implemented
iOS no change required
Android

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

@insbodhi insbodhi changed the title resolves On Android devices "getPointAtLength" function returns incorrect values #1721 resolves On Android devices "getPointAtLength" function returns incorrect values Mar 22, 2022
@NamithaRavy
Copy link

Hi Team,
I found this solution useful. Please merge this PR.

Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good! Thanks for your contribution 🎉

@WoLewicki WoLewicki merged commit 0409f37 into software-mansion:main Sep 15, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On Android devices "getPointAtLength" function returns incorrect values
4 participants