Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix constructor with deprecated context #1822

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Fix constructor with deprecated context #1822

merged 1 commit into from
Aug 9, 2022

Conversation

hyochan
Copy link
Contributor

@hyochan hyochan commented Aug 3, 2022

Summary

The constructor with context is deprecated and occurs types error in react-native@69+.
See https://reactjs.org/docs/legacy-context.html

Test Plan

With react-native 0.69+ project try below.

const AnimCircle = Animated.createAnimatedComponent(Circle);

then the error occurs.
Screen Shot 2022-08-03 at 2 14 13 PM

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

WoLewicki
WoLewicki approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution 🎉

@WoLewicki WoLewicki merged commit 8d0ae5e into software-mansion:main Aug 9, 2022
@hyochan hyochan deleted the fix/deprecated-context branch September 20, 2022 09:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@WoLewicki WoLewicki WoLewicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyochan @WoLewicki