Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: add support base64 uri type in SvgUri component #2444

Merged
merged 2 commits into from
Sep 24, 2024
Merged

feat: add support base64 uri type in SvgUri component #2444

merged 2 commits into from
Sep 24, 2024

Conversation

bohdanprog
Copy link
Member

Summary

Feature #2142

Add support for data: image/svg+XML; Base64 format.

Test Plan

TestExample app -> src -> Test2142

Compatibility

OS Implemented
iOS ✅
MacOS ✅
Android ✅
Web ✅

@bohdanprog bohdanprog requested a review from jakex7 September 10, 2024 12:39
@bohdanprog bohdanprog self-assigned this Sep 10, 2024
@bohdanprog bohdanprog marked this pull request as ready for review September 10, 2024 14:53
jakex7
jakex7 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@jakex7 jakex7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakex7 jakex7 merged commit 14a131c into main Sep 24, 2024
3 checks passed
@jakex7 jakex7 deleted the @bohdanprog/add-support-SvgUri-base64 branch September 24, 2024 08:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jakex7 jakex7 jakex7 approved these changes

Assignees

@bohdanprog bohdanprog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bohdanprog @jakex7