feat: make RenderableView.hitTest public to create a cross-library interface
#2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakex7
approved these changes
Nov 28, 2024
jakex7
changed the title
RenderableView.hitTest public to create a cross-library interfaceRenderableView.hitTest public to create a cross-library interface
4 tasks
jakex7
pushed a commit
that referenced
this pull request
Jan 15, 2025
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect --> # Summary This PR reverts #2555, as `RenderableView.hitTest()` can be replaced by `SvgView.reactTagForTouch()`, which is already `public`. This PR also changes the `package-private` `getSvgView()` method of `VirtualView` to `public`. This change has been made to handle hit detection of transformed `VirtualView`s, as `RenderableView`'s `hitTest()` doesn't take transformations into account, while `SvgView`'s `reactTagForTouch()` does. Making `getSvgView()` public is necessary for integrating RNSVG support into RNGH. More details [here](software-mansion/react-native-gesture-handler#3242). ## Test Plan Run the example from the RNGH - RNSVG [integration PR](software-mansion/react-native-gesture-handler#3242). ## Compatibility | OS | Implemented | | ------- | :---------: | | Android | ✅ |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding an
RNGH <-> RNSVGinterface requires usage ofRenderableView.hitTestto work. (link)Currently,
RenderableView.hitTestispackage-private, meaning it cannot be accessed by other packages.This change does not change any functionality of the library, it only exposes existing functions to other libraries.
I only made public those
hitTestimplementation which are strictly necessary for this interface, this is why multiple, if not mosthitTestimplementations remainpackage-privatedespite the changes made in the PR.Test Plan
What's required for testing (prerequisites)?
RNSVG'spaper-exampleappWhat are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdI updated the typed files (typescript)__tests__folder